Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug logging fails to capture RPC request details #695

Closed
chrisrossi opened this issue Jul 27, 2021 · 0 comments · Fixed by #696
Closed

Debug logging fails to capture RPC request details #695

chrisrossi opened this issue Jul 27, 2021 · 0 comments · Fixed by #696
Assignees
@chrisrossi
Labels
api: datastore Issues related to the googleapis/python-ndb API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chrisrossi
Copy link
Contributor

When logging RPC calls for debugging, the name of the call is logged, but not the request object, which would be useful to have.
@chrisrossi chrisrossi added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jul 27, 2021
@chrisrossi chrisrossi self-assigned this Jul 27, 2021
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Jul 27, 2021
chrisrossi pushed a commit to chrisrossi/python-ndb that referenced this issue Jul 27, 2021
fix: add rpc request object to debug logging
c9dd0fe 
Fixes googleapis#695
@chrisrossi chrisrossi mentioned this issue Jul 27, 2021
Merged
chrisrossi pushed a commit to chrisrossi/python-ndb that referenced this issue Jul 28, 2021
fix: add rpc request object to debug logging
b0ecd26 
Fixes googleapis#695
tseaver pushed a commit that referenced this issue Jul 29, 2021
fix: add rpc request object to debug logging (#696)
45e590a 
Fixes #695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisrossi chrisrossi

Labels
api: datastore Issues related to the googleapis/python-ndb API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add rpc request object to debug logging chrisrossi/python-ndb
1 participant
@chrisrossi