Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Migration Notes. #152

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Conversation

chrisrossi
Copy link
Contributor

Added RedisCache to top-level exports (forgot to do this earlier).

Moved _db_set_value() and _db_get_value() from the several
subclasses up to model.Property so we can not implement them in a
single place.

Changed some NotImplementedErrors into NoLongerImplementedErrors
to make explicit decision not to implement some old functionality.

Added ``RedisCache`` to top-level exports (forgot to do this earlier).

Moved ``_db_set_value()`` and ``_db_get_value()`` from the several
subclasses up to ``model.Property`` so we can not implement them in a
single place.

Changed some ``NotImplementedError``s into ``NoLongerImplementedError``s
to make explicit decision not to implement some old functionality.
@chrisrossi chrisrossi requested a review from cguardia August 7, 2019 15:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2019
@chrisrossi
Copy link
Contributor Author

I know there are other documents aimed at Migration floating around, but we need one that is definitively complete so we can tell when something can be crossed off our TODO.

Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks.

- `Query.run_to_queue` is no longer implemented. Appears to be aimed at
internal usage, despite being nominally public.

These options classes appear not have been used directly by users and are not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to have been used?

@chrisrossi chrisrossi merged commit b3f01e9 into googleapis:master Aug 7, 2019
@chrisrossi chrisrossi deleted the migration-notes branch January 12, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants