Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an exception when storing entity with partial key without Datastore. #171

Merged
merged 3 commits into from
Aug 23, 2019
Merged

Raise an exception when storing entity with partial key without Datastore. #171

merged 3 commits into from
Aug 23, 2019

Conversation

chrisrossi
Copy link
Contributor

Fixes #156

@chrisrossi chrisrossi requested a review from cguardia August 23, 2019 18:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2019
cguardia
cguardia approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrisrossi chrisrossi merged commit 6e9ba10 into googleapis:master Aug 23, 2019
@chrisrossi chrisrossi deleted the partial-keys-without-datastore branch August 23, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguardia cguardia cguardia approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Odd behavior with use_datastore=False and storing entities with incomplete keys
3 participants
@chrisrossi @cguardia @googlebot