Prove tasklets can be Python 2.7 and 3.7 compatible. #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If our codebase is to be compatible with Python 2.7, we have to change
all instances where we
return
from a tasklet to usingraise ndb.Return()
, because Python 2 doesn't allow returning a value from agenerator.
Python 3.7 also doesn't allow raising StopIteration from inside of a
generator, which, on first blush, seemed to preclude having a common
codebase that was both Python 2.7 and 3.7 compatible. As it turns out,
though, we can just make
tasklets.Return
inherit fromException
instead of fromStopIteration
.Crisis averted.