Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't set key on structured property entities. #312

Merged
merged 1 commit into from
Feb 5, 2020
Merged

fix: Don't set key on structured property entities. #312

merged 1 commit into from
Feb 5, 2020

Conversation

chrisrossi
Copy link
Contributor

Fixes #281.

@chrisrossi chrisrossi requested a review from cguardia January 30, 2020 21:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020
@chrisrossi chrisrossi mentioned this pull request Jan 30, 2020
Closed
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2020
cguardia
cguardia approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I missed this one before.

@chrisrossi chrisrossi merged commit 63f3d94 into googleapis:master Feb 5, 2020
@chrisrossi chrisrossi deleted the fix-281 branch February 5, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguardia cguardia cguardia approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ndb.Key, Cache, and Pickle - ValueError: (None, 'ID/name was not a string or integer.')
5 participants
@chrisrossi @cguardia @crwilcox @googlebot @yoshi-kokoro