Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disuse __slots__ in most places #330

Merged
merged 1 commit into from
Feb 11, 2020
Merged

fix: disuse __slots__ in most places #330

merged 1 commit into from
Feb 11, 2020

Conversation

chrisrossi
Copy link
Contributor

In Python 2.7, classes which use __slots__ can't be pickled. Users
have reported problems trying to pickle NDB entities, indicating there
is some perceived use case for pickling entities.

Fixes #311

fix: disuse __slots__ in most places
f065e75 
In Python 2.7, classes which use `__slots__` can't be pickled. Users
have reported problems trying to pickle NDB entities, indicating there
is some perceived use case for pickling entities.

Fixes googleapis#311
@chrisrossi chrisrossi requested a review from cguardia February 11, 2020 16:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2020
@chrisrossi
Copy link
Contributor Author

chrisrossi commented Feb 11, 2020 •
edited
Loading

Kokoro had a transient error related to intersphinx:

failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://grpc.io/grpc/python/objects.inv' not fetchable due to <class 'requests.exceptions.ConnectionError'>: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
Command sphinx-build -W -T -N -b html -d docs/_build/doctrees/ docs/ docs/_build/html/ failed with exit code 2

@chrisrossi chrisrossi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2020
cguardia
cguardia approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@chrisrossi chrisrossi merged commit a8b723b into googleapis:master Feb 11, 2020
@chrisrossi chrisrossi deleted the fix-311 branch February 11, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguardia cguardia cguardia approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pickling problematic with Python 2
4 participants
@chrisrossi @cguardia @googlebot @yoshi-kokoro