fix: allow legacy ndb to read LocalStructuredProperty entities. #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
cguardia
force-pushed
the
repeated-local-structured-property
branch
from
0c0ae17 to
0300ab3
Compare
cguardia
force-pushed
the
repeated-local-structured-property
branch
from
27c431e to
9fa96e9
Compare
cguardia
added
the
kokoro:force-run
Legacy ndb is not able to read back serialized entities when using repeated LocalStructuredProperty.
cguardia
force-pushed
the
repeated-local-structured-property
branch
from
5787ce1 to
62114a3
Compare
yoshi-kokoro
removed
the
kokoro:force-run
A single typo was cut and pasted into multiple places.
|
does it take |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy ndb is not able to read back serialized entities when using repeated LocalStructuredProperty. This fix saves those entities without serialization when legacy data is set in the context (default behavior)