fix: move stub (grpc communication channel) to client #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings our practice in line with `google.cloud.datastore`, which also creates one channel per client. This works around a resource leak issue by not requiring the channel to clean up after itself properly in normal usage. The root cause of that issue seems to lie somewhere in `google.auth`, which is where I will follow up. Fixes googleapis#343
googlebot
added
the
cla: yes
Closed
chrisrossi
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chrisrossi
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings our practice in line with
google.cloud.datastore, whichalso creates one channel per client. This works around a resource leak issue
by not requiring the channel to clean up after itself properly in normal
usage. The root cause of that issue seems to lie somewhere in
google.auth, which is where I will follow up.Fixes #343