Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rpc request object to debug logging #696

Merged
merged 2 commits into from
Jul 29, 2021
Merged

fix: add rpc request object to debug logging #696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0ecd26
fix: add rpc request object to debug logging
Jul 27, 2021
5acb708
Merge branch 'master' into fix-695
Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions google/cloud/ndb/_datastore_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ def rpc_call():
rpc = _remote.RemoteCall(call, rpc_name)
utils.logging_debug(log, rpc)
utils.logging_debug(log, "timeout={}", timeout)
utils.logging_debug(log, request)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is potential overhead -- the request protobuf message could be arbitrarily large, especially for write operations. If that isn't a concern (becasue utils.logging_debug does a short-curcuit), then this should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils.logging_debug does nothing unless the NDB_DEBUG environment variable is set to something truthy.


try:
result = yield rpc
Expand Down