Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow for legacy repeated structured properties with empty values #702

Merged
merged 2 commits into from
Jul 30, 2021
Merged

fix: allow for legacy repeated structured properties with empty values #702

merged 2 commits into from
Jul 30, 2021

Conversation

chrisrossi
Copy link
Contributor

Fixes #694

@chrisrossi chrisrossi requested a review from andrewsg as a code owner July 29, 2021 18:53
@chrisrossi chrisrossi requested a review from a team July 29, 2021 18:53
@chrisrossi chrisrossi requested a review from a team as a code owner July 29, 2021 18:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2021
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Jul 29, 2021
@chrisrossi chrisrossi requested review from tseaver and jimfulton July 29, 2021 18:53
@chrisrossi chrisrossi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2021
@chrisrossi chrisrossi merged commit 60c293d into googleapis:master Jul 30, 2021
@chrisrossi chrisrossi deleted the fix-694 branch July 30, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@jimfulton jimfulton Awaiting requested review from jimfulton

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in 1.10.0 causing error when saving entity with repeating structured property value of empty list
3 participants
@chrisrossi @tseaver @yoshi-kokoro