Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spanner): Issue#1143 - Update dependency #1158

Merged
merged 16 commits into from
Aug 26, 2024
Merged

chore(spanner): Issue#1143 - Update dependency #1158

merged 16 commits into from
Aug 26, 2024

Conversation

bhatt4982
Copy link
Contributor

chore(spanner): Issue#1143 - Update dependency

  • Move grpc-interceptor to extras_required named testing

Fixes #1143 🦕

@bhatt4982 bhatt4982 requested review from a team as code owners July 8, 2024 04:10
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Jul 8, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2024
@harshachinta
Copy link
Contributor

harshachinta commented Jul 9, 2024 •
edited
Loading

@bhatt4982 The presubmits are failing since the tetsing dependency is not getting installed when installing depenedencies.
You will need to add this testing dependency as extra similar to tracing ones here. ex: pip install mypackage[tracing, testing]

  1. python-spanner/noxfile.py

    Line 60 in 1659ed3

    SYSTEM_TEST_EXTRAS: List[str] = [
  2. Please look at references to tracing and add testing at appropriate places

    python-spanner/noxfile.py

    Line 168 in 1659ed3

    session.install("-e", ".[tracing]", "-c", constraints_path)

This reference might help you understand
https://packaging.python.org/en/latest/tutorials/installing-packages/#installing-extras

@bhatt4982
chore(spanner): Issue#1143 - Update dependency
b6fe4d4 
- add dependency 'testing' for pretest
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 9, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
@bhatt4982
chore(spanner): Issue#1143 - Update dependency
74b2312 
- add dependency 'testing' for docs and docfx sessions
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
@harshachinta
Copy link
Contributor

@bhatt4982

  1. We will need to update owlbot.py https://github.com/googleapis/python-spanner/blob/112e74e6f15dc883dc347e82c890251c53a51a02/owlbot.py#L131C26-L131C33 to add testing dependency similar to tracing. Otherwise the automated PR might remove these changes,
  2. Can you fix the lint? Command: nox -s blacken

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024
@harshachinta
Copy link
Contributor

@parthea Can you help with a quick review of this PR?

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2024
@harshachinta harshachinta merged commit 44434aa into googleapis:main Aug 26, 2024
11 of 13 checks passed
@bhatt4982 bhatt4982 deleted the Issue1143-update-dependencies branch August 27, 2024 06:08
@asottile-sentry asottile-sentry mentioned this pull request Sep 4, 2024
Merged
rbarrette pushed a commit to rbarrette/python-spanner that referenced this pull request Sep 5, 2024
Revert "chore(spanner): Issue#1143 - Update dependency (googleapis#1158…
dfc03c8 
…)"

This reverts commit 44434aa.
@rbarrette rbarrette mentioned this pull request Sep 5, 2024
Closed
rbarrette pushed a commit to rbarrette/python-spanner that referenced this pull request Sep 5, 2024
@rbarrette
Revert "chore(spanner): Issue#1143 - Update dependency (googleapis#1158…
6046f83 
…)"

This reverts commit 44434aa.
rbarrette added a commit to rbarrette/python-spanner that referenced this pull request Sep 5, 2024
@rbarrette
Revert "chore(spanner): Issue#1143 - Update dependency (googleapis#1158…
5b486df 
…)"

This reverts commit 44434aa.
harshachinta added a commit that referenced this pull request Sep 6, 2024
@harshachinta
Revert "chore(spanner): Issue#1143 - Update dependency (#1158)"
e4fbe10 
This reverts commit 44434aa.
@harshachinta harshachinta mentioned this pull request Sep 6, 2024
Merged
harshachinta added a commit that referenced this pull request Sep 6, 2024
@harshachinta
Revert "chore(spanner): Issue#1143 - Update dependency (#1158)" (#1197)
92f05ed 
This reverts commit 44434aa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshachinta harshachinta harshachinta approved these changes

Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc-interceptor is listed as a dependency but is only used for testing utilities
4 participants
@bhatt4982 @harshachinta @asthamohta @yoshi-kokoro