Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add region tags for Transfer Manager samples #1110

Merged
merged 3 commits into from
Aug 23, 2023
Merged

chore: Add region tags for Transfer Manager samples #1110

merged 3 commits into from
Aug 23, 2023

Conversation

andrewsg
Copy link
Contributor

No description provided.

@andrewsg andrewsg requested a review from cojenco August 16, 2023 22:50
@andrewsg andrewsg requested review from a team as code owners August 16, 2023 22:50
@snippet-bot
Copy link

snippet-bot bot commented Aug 16, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Aug 16, 2023
cojenco
cojenco approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question on wrapping blank lines, otherwise LGTM, thanks!

samples/snippets/storage_transfer_manager_download_all_blobs.py Outdated
@@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# [START storage_transfer_manager_download_all_blobs]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, there will be extra blank lines wrapping the code snippet in sample browser with this line after/before the region tags.

@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9a189da into main Aug 23, 2023
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the region_tags branch August 23, 2023 00:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@vchudnov-g vchudnov-g Awaiting requested review from vchudnov-g vchudnov-g is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewsg @cojenco