Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resumable media integration #1283

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

andrewsg
Copy link
Contributor

@andrewsg andrewsg commented May 31, 2024

This merges the "resumable media integration" project into a separate base branch. The base branch is designed to produce a readable diff for this PR. The only change to the base branch from main is copying the resumable media library into this library, in the correct directory/module structure, without further modification.

@andrewsg andrewsg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 31, 2024
@andrewsg andrewsg requested review from a team as code owners May 31, 2024 19:04
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label May 31, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label May 31, 2024
@danielduhh danielduhh requested a review from cojenco June 17, 2024 21:44
@andrewsg andrewsg force-pushed the resumable-media-integration branch from 5797001 to fdfcff9 Compare June 24, 2024 20:12
@andrewsg andrewsg requested a review from a team as a code owner June 24, 2024 20:12
@andrewsg andrewsg requested review from iennae and removed request for a team June 24, 2024 20:12
Copy link

snippet-bot bot commented Jun 24, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@andrewsg andrewsg changed the base branch from 3.0-devel to resumable-media June 24, 2024 20:18
Copy link

conventional-commit-lint-gcf bot commented Jun 24, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@andrewsg andrewsg removed the request for review from iennae June 24, 2024 20:18
@andrewsg andrewsg changed the title Resumable media integration feat: resumable media integration Jun 24, 2024
@andrewsg andrewsg assigned cojenco and unassigned BrennaEpp Jun 25, 2024
update from base branch
@andrewsg andrewsg force-pushed the resumable-media-integration branch from fdfcff9 to aad4e11 Compare June 26, 2024 15:56
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jun 26, 2024
noxfile.py Show resolved Hide resolved
google/cloud/storage/_media/common.py Show resolved Hide resolved
google/cloud/storage/exceptions.py Show resolved Hide resolved
google/cloud/storage/exceptions.py Outdated Show resolved Hide resolved
google/cloud/storage/_helpers.py Show resolved Hide resolved
andrewsg and others added 2 commits July 8, 2024 10:06
Co-authored-by: cojenco <cathyo@google.com>
@andrewsg andrewsg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 8, 2024
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andrewsg andrewsg merged commit 1c7caca into resumable-media Jul 8, 2024
7 of 9 checks passed
@andrewsg andrewsg deleted the resumable-media-integration branch July 8, 2024 17:49
andrewsg added a commit that referenced this pull request Dec 5, 2024
Integrate the google-resumable-media library into python-storage.

---------

Co-authored-by: cojenco <cathyo@google.com>
andrewsg added a commit that referenced this pull request Dec 10, 2024
Integrate the google-resumable-media library into python-storage.

---------

Co-authored-by: cojenco <cathyo@google.com>
andrewsg added a commit that referenced this pull request Dec 10, 2024
Integrate the google-resumable-media library into python-storage.

---------

Co-authored-by: cojenco <cathyo@google.com>
andrewsg added a commit that referenced this pull request Dec 11, 2024
Integrate the google-resumable-media library into python-storage.

---------

Co-authored-by: cojenco <cathyo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants