-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add gRPC GAPIC layer for Storage V1 #270
base: main
Are you sure you want to change the base?
Conversation
The
|
@@ -32,6 +32,10 @@ | |||
"google-auth >= 1.11.0, < 2.0dev", | |||
"google-cloud-core >= 1.4.1, < 2.0dev", | |||
"google-resumable-media >= 1.0.0, < 2.0dev", | |||
"google-api-core[grpc] >= 1.21.0, < 2.0.0dev", | |||
"grpc-google-iam-v1 >= 0.12.3", | |||
"proto-plus >= 1.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these dependencies are python3+. We could add this and conditionally install, though possibly best to hold this pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankyn to figure out how to move this PR forward along.
#269 asked about publishing the grpc proto surface. This PR adds gapic bazel generation of storage_v1
marking as do not merge for now but could be installed with
pip install git+https://github.com/googleapis/python-storage@gapic-generation