feat: add list prefix method #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
frankyn
reviewed
Oct 21, 2020
| @@ -1263,6 +1285,102 @@ def list_blobs( | |||
| iterator.prefixes = set() | |||
| return iterator | |||
|
|
|||
| def list_prefixes( | |||
There was a problem hiding this comment.
Pending feedback from issue filer. I'm not convinced this is the right path forward.
frankyn
added
the
do not merge
|
Looking a little more deeply at the page_iterator and Storage Objects: list JSON API it seems both items and prefixes are always returned in the same response, so adding Perhaps the more general solution would be to create an listing method that returns an iterator of pages, with each page having both an iterator of prefixes and an iterator or blobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294