Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set custom_time on uploads #374

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Feb 8, 2021

The custom_time property was incorrectly not included as a field
that could be set on object upload.

Fixes #372

The custom_time property was incorrectly not included as a field
that could be set on object upload.

Fixes googleapis#372
@tritone tritone requested a review from a team February 8, 2021 19:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Feb 8, 2021
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris!

@tritone tritone merged commit f048be1 into googleapis:master Feb 8, 2021
@tritone tritone deleted the customtime-upload branch February 8, 2021 20:07
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
The custom_time property was incorrectly not included as a field
that could be set on object upload.

Fixes googleapis#372
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
The custom_time property was incorrectly not included as a field
that could be set on object upload.

Fixes googleapis#372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blob's custom_time is lost on upload.
2 participants