-
Notifications
You must be signed in to change notification settings - Fork 45
docs: connect Python Translate client library to nebulous serverless example #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I wonder if we can increase the visibility of this by adding it to the README on the top directory. Not sure if that's a client library style though 🤔
@dandhlee Added a section at the bottom of the top-level |
Have a good weekend! :D I don't feel qualified enough to touch on a client library for common style, I'll wait for Bu Sun to chime in 😅 |
NP Dan! Also added Eric (hi!) and Torry (hi to you too) as managers. |
@@ -0,0 +1,3 @@ | |||
For a complete sample Python "mini-Google Translate" web app using the [Google Cloud Translation API](https://cloud.google.com/translate), go to <https://github.com/googlecodelabs/cloud-nebulous-serverless-python>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should move this text to the previous file (the top-level README). Placing this README leaves the important information buried within the repo and may be confusing to the customers who find it.
Additionally, I would make sure that you've added a link to your app in the official Translation documentation on CGC.
Thx all. Can someone merge for me (or give me write perms to do so)? |
Thx for the merge @dandhlee (and everyone else for the LGTMs)! |
🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/googleapis/python-translate/compare/v3.1.0...v3.2.0) (2021-05-28) ### Features * support self-signed JWT flow for service accounts ([959a35c](https://www.github.com/googleapis/python-translate/commit/959a35c85e32867ed63c63d96593a240a5e8a1c4)) ### Bug Fixes * add async client to %name_%version/init.py ([959a35c](https://www.github.com/googleapis/python-translate/commit/959a35c85e32867ed63c63d96593a240a5e8a1c4)) * **deps:** add packaging requirement ([959a35c](https://www.github.com/googleapis/python-translate/commit/959a35c85e32867ed63c63d96593a240a5e8a1c4)) ### Documentation * connect Python Translate client library to nebulous serverless example ([#162](https://www.github.com/googleapis/python-translate/issues/162)) ([2986864](https://www.github.com/googleapis/python-translate/commit/2986864db391e5216dbead83eb822fd1fb2c19d0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Not adding new code but linking to another repo with a sample app using this API as another sample for users; added folder with README per @busunkim96