-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add extra-files input #410
Conversation
@jcornaz try installing the latest version of |
Thanks @bcoe. It does work now :-) |
@jcornaz mind rebasing? |
@bcoe I rebased 👍 |
@@ -55,6 +55,7 @@ Automate releases with Conventional Commit Messages. | |||
| `monorepo-tags` | add prefix to tags and branches, allowing multiple libraries to be released from the same repository. | | |||
| `changelog-types` | A JSON formatted String containing to override the outputted changelog sections | | |||
| `version-file` | provide a path to a version file to increment (used by ruby releaser) | | |||
| `extra-files` | add extra-files to bump using the [generic updater](https://github.com/googleapis/release-please/blob/main/docs/customizing.md#updating-arbitrary-files) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small additional example in README.md, that demonstrates how to provide multiline input I think would be valuable, I assume it's:
extra-files:
- file a
- file b
```?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll add an example.
Here is how to provide multiline inputs:
extra-files: |
file1
file2
IMO the syntax you mentioned would have bean nicer, because that's how we are used to define lists in yaml, but github actions uses multi-line input instead: actions/toolkit#829
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcoe I am not sure where I should add the example in the readme. Should it be directly in the table of inputs? Or should I add a dedicated section later in the readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcornaz I'd just add an extra section after:
Creating major/minor tags
Along the lines of Adding additional files
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the readme
@jcornaz thank you 🥳 |
How does this work with updating xml or json files? How can I set the xpath? |
You cannot set a XPath. In the file you want to update, you have to comment in the file where are the part want to update. See: https://github.com/googleapis/release-please/blob/main/docs/customizing.md#updating-arbitrary-files for more details Example: <myxml>
<version>1.0.0</version> <!-- x-release-please-version -->
</myxml> |
Thanks @jcornaz . I've tried that with the |
Mmh strange, it should work. I suggest you open an issue and share an example of how to reproduce. |
resolve #343
Add the
extra-files
input option.See: https://github.com/googleapis/release-please/blob/main/docs/customizing.md#updating-arbitrary-files