feat: support GitHub automated release notes #1087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
If you manually call the generate release notes API, rather than passing "generate_release_notes: true" to the create release API you would be able to append a header and footer prior to publishing |
|
@bcoe Hi, yes, that's better than nothing but still doesn't give us a way to add custom text before/after, and this is what we needed. Looking at the template they implemented for Releases I think the best place for this custom text would be their new Release template itself. Here I asked for this to be implemented: community/community#6417 |
|
Got an update from GitHub, seems they won't be implementing this for now: community/community#6417 (comment) |
bcoe
added
the
do not merge
|
sitting on this feature for a bit until @chingor13 finishes refactor. |
|
Note: this is included in #1120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow you to use
release-pleasefor version bumps and CHANGELOG generation, in conjunction with GitHub's new auto-generated release notes.@ilya-lesikov I had your PR in mind working on this, in a perfect world we'd be able to use GitHub's new
.github/release.ymlto customize releases, without needing to add templating support torelease-please.Looking at the features in GitHub's auto-generated releases, I don't think it quite matches what you're looking for though?
CC: @MylesBorins