Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for yarn workspace versions #1819

Merged
merged 3 commits into from
Jan 24, 2023
Merged

feat: add support for yarn workspace versions #1819

merged 3 commits into from
Jan 24, 2023

Conversation

mpetrunic
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1587 🦕
Fixes #1098 🦕
Superseeds #1449

@mpetrunic mpetrunic requested a review from a team as a code owner January 24, 2023 12:08
@mpetrunic mpetrunic requested a review from a team January 24, 2023 12:08
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 24, 2023
chingor13
chingor13 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit 8b0cc7d into googleapis:main Jan 24, 2023
@release-please release-please bot mentioned this pull request Jan 24, 2023
Merged
@mpetrunic mpetrunic deleted the feat/support-workspace-version branch January 25, 2023 04:51
@nahsi nahsi mentioned this pull request Feb 6, 2023
Closed
@mpetrunic mpetrunic mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin node_workspace doesn't work with pnpm? Add support for pnpm
2 participants
@mpetrunic @chingor13