Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect tagSeparator and includeVInTag everywhere #2283

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: respect tagSeparator and includeVInTag everywhere #2283

merged 3 commits into from
Sep 11, 2024

Conversation

niieani
Copy link
Contributor

@niieani niieani commented May 5, 2024

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2282 🦕

@niieani niieani requested review from a team as code owners May 5, 2024 03:09
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 5, 2024
@niieani niieani mentioned this pull request May 5, 2024
Closed
@niieani
Copy link
Contributor Author

niieani commented Jul 5, 2024

Hi @chingor13, anything I can do to help get this bugfix merged?

@chingor13 chingor13 merged commit dad27e3 into googleapis:main Sep 11, 2024
11 checks passed
@release-please release-please bot mentioned this pull request Sep 11, 2024
Merged
@chingor13 chingor13 mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The previous tag name does not respect custom tagSeparator and/or includeVInTag: false in the generated PR
2 participants
@niieani @chingor13