Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove whitespace character from ${component} #2330

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kiruyuto
Copy link

@Kiruyuto Kiruyuto commented Jul 8, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1626 🦕

Removes (space) character from component effectively allowing to use component as a scope or in any other "complex" scenario, eg.:

"pull-request-title-pattern": "chore(${component}): v${version}"

Prior to this change attempting to do so resulted in this kind of behaviour
image

@Kiruyuto Kiruyuto requested review from a team as code owners July 8, 2024 23:38
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ${component} without whitespace of the beginning
2 participants