feat: support @ and / when falling back to tags #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
bcoe
added a commit
to googleapis/release-please-action
that referenced
this pull request
Dec 29, 2020
bcoe
added a commit
to googleapis/release-please-action
that referenced
this pull request
Dec 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
==========================================
+ Coverage 83.07% 84.23% +1.15%
==========================================
Files 45 45
Lines 5269 5314 +45
Branches 444 431 -13
==========================================
+ Hits 4377 4476 +99
+ Misses 891 837 -54
Partials 1 1
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating moving a lerna project over to release-please, I noticed that tags have the
@suffix rather than-. There have been a couple other languages that use releasa-please where the tags use/, rather than-.Instead of making each of these a special case, this PR checks each suffix, this will make it easier to migrate to release-please from other tools.