feat(datastore-lock)!: factoring out datastore-lock #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
bcoe
reviewed
May 13, 2021
| return false; | ||
| } | ||
|
|
||
| private async _acquire(): Promise<AcquireResult> { |
There was a problem hiding this comment.
Fun fact, I learned recently that private fields aren't actually private outside of the context of TypeScript, so when I actually wanted private methods, I ended up using symbols as method names:
https://github.com/yargs/yargs/blob/master/lib/yargs-factory.ts#L88
I'm not suggesting we change anything, just wanted to share this surprising TypeScript behavior.
tmatsuo
added
the
do not merge
|
I'll add release config first :) |
tmatsuo
changed the title
tmatsuo
removed
the
do not merge
|
I'm trying to rewrite the first commit message to be a breaking change, but my local git client drops the exclamation mark. I'm going to squash locally and re-push the change with a new commit message. |
* changed the namespace to github-automations * changed the version to 0.1.0
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small library is initially implemented in
blunderbuss, but it should be useful for some other bots, so I'm trying to make it a npm package.