Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update integration tests #258

Merged
merged 25 commits into from
Sep 6, 2023
Merged

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Jul 26, 2023

Updates the integration tests based on a number of observations:

  1. The migration tests are too slow, as these generate a huge number of different schema versions. These are therefore skipped on production and only executed on the emulator.
  2. The with_separate_database tests did not disconnect from the database after it was dropped. This caused occasional Database not found errors.
  3. The rename_columns_test did not use DDL batching.
  4. ActiveRecord 7.0.6 and 7.0.7 were not included in the tests.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/ruby-spanner-activerecord API. label Jul 26, 2023
@olavloite olavloite force-pushed the disable-selected-integration-tests branch from a450a62 to 985e744 Compare August 28, 2023 05:30
@olavloite olavloite changed the title build: disable selected integration tests to check what causes timeout build: update integration tests Sep 2, 2023
@olavloite olavloite marked this pull request as ready for review September 2, 2023 16:12
@olavloite olavloite requested a review from a team as a code owner September 2, 2023 16:12
@olavloite olavloite merged commit 937e5b5 into main Sep 6, 2023
30 checks passed
@olavloite olavloite deleted the disable-selected-integration-tests branch September 6, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/ruby-spanner-activerecord API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants