Skip to content

Commit

Permalink
[ggj][bazel] fix: add google/type:type_java_proto as default test dep (
Browse files Browse the repository at this point in the history
…#571)

* fix: handle empty method_signature in parsing protos

* fix: add google/type:type_java_proto as default test dep
  • Loading branch information
miraleung authored Nov 26, 2020
1 parent b0a8ba8 commit 3b7bb40
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 1 addition & 0 deletions rules_java_gapic/java_gapic.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ def java_gapic_library(

# Test deps.
actual_test_deps = test_deps + actual_deps + [
"@com_google_googleapis//google/type:type_java_proto", # Commonly used.
"@com_google_api_gax_java//gax-grpc:gax_grpc_testlib",
"@com_google_api_gax_java//gax:gax_testlib",
"@com_google_code_gson_gson//jar",
Expand Down
2 changes: 0 additions & 2 deletions test/integration/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ java_gapic_library(
"@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",
"@com_google_googleapis//google/iam/v1:iam_java_proto",
"@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_proto",
"@com_google_googleapis//google/type:type_java_proto",
],
)

Expand All @@ -75,7 +74,6 @@ java_gapic_assembly_gradle_pkg(
"@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",
"@com_google_googleapis//google/cloud/asset/v1:asset_proto",
"@com_google_googleapis//google/cloud/orgpolicy/v1:orgpolicy_java_proto",
"@com_google_googleapis//google/identity/accesscontextmanager/type:type_java_proto",
"@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_java_proto",
],
)
Expand Down

0 comments on commit 3b7bb40

Please sign in to comment.