Skip to content

Commit

Permalink
fix: Change the default scope of gax from implementation to api in au…
Browse files Browse the repository at this point in the history
…to-generated gradle files for self-service client libraries. (#1374)
  • Loading branch information
blakeli0 authored Feb 22, 2023
1 parent ecb3fdf commit eee7573
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions rules_java_gapic/resources/gradle/client_grpc.gradle.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ compileJava.options.encoding = 'UTF-8'
javadoc.options.encoding = 'UTF-8'

dependencies {
implementation 'com.google.api:gax:{{version.gax}}'
api 'com.google.api:gax:{{version.gax}}'
testImplementation 'com.google.api:gax:{{version.gax}}:testlib'
implementation 'com.google.api:gax-grpc:{{version.gax_grpc}}'
api 'com.google.api:gax-grpc:{{version.gax_grpc}}'
testImplementation 'com.google.api:gax-grpc:{{version.gax_grpc}}:testlib'
implementation 'io.grpc:grpc-protobuf:{{version.io_grpc}}'
api 'io.grpc:grpc-protobuf:{{version.io_grpc}}'
testImplementation 'io.grpc:grpc-stub:{{version.io_grpc}}'
testImplementation 'io.grpc:grpc-netty-shaded:{{version.io_grpc}}'
testImplementation '{{maven.junit_junit}}'
Expand Down
8 changes: 4 additions & 4 deletions rules_java_gapic/resources/gradle/client_grpcrest.gradle.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ compileJava.options.encoding = 'UTF-8'
javadoc.options.encoding = 'UTF-8'

dependencies {
implementation 'com.google.api:gax:{{version.gax}}'
api 'com.google.api:gax:{{version.gax}}'
testImplementation 'com.google.api:gax:{{version.gax}}:testlib'
implementation 'com.google.api:gax-grpc:{{version.gax_grpc}}'
api 'com.google.api:gax-grpc:{{version.gax_grpc}}'
testImplementation 'com.google.api:gax-grpc:{{version.gax_grpc}}:testlib'
implementation 'com.google.api:gax-httpjson:{{version.gax_httpjson}}'
api 'com.google.api:gax-httpjson:{{version.gax_httpjson}}'
testImplementation 'com.google.api:gax-httpjson:{{version.gax_httpjson}}:testlib'
implementation 'io.grpc:grpc-protobuf:{{version.io_grpc}}'
api 'io.grpc:grpc-protobuf:{{version.io_grpc}}'
testImplementation 'io.grpc:grpc-stub:{{version.io_grpc}}'
testImplementation 'io.grpc:grpc-netty-shaded:{{version.io_grpc}}'
testImplementation '{{maven.junit_junit}}'
Expand Down
4 changes: 2 additions & 2 deletions rules_java_gapic/resources/gradle/client_rest.gradle.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ compileJava.options.encoding = 'UTF-8'
javadoc.options.encoding = 'UTF-8'

dependencies {
implementation 'com.google.api:gax:{{version.gax}}'
api 'com.google.api:gax:{{version.gax}}'
testImplementation 'com.google.api:gax:{{version.gax}}:testlib'
implementation 'com.google.api:gax-httpjson:{{version.gax_httpjson}}'
api 'com.google.api:gax-httpjson:{{version.gax_httpjson}}'
testImplementation 'com.google.api:gax-httpjson:{{version.gax_httpjson}}:testlib'
testImplementation '{{maven.junit_junit}}'

Expand Down

0 comments on commit eee7573

Please sign in to comment.