Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for creating an httpJson client is wrong #1034

Closed
blakeli0 opened this issue Sep 6, 2022 · 1 comment
Closed

Documentation for creating an httpJson client is wrong #1034

blakeli0 opened this issue Sep 6, 2022 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@blakeli0
Copy link
Collaborator

blakeli0 commented Sep 6, 2022

The current documentation for creating an httpJson client is wrong.

Current:

LanguageServiceSettings languageServiceSettings =
    LanguageServiceSettings.newBuilder()
        .setTransportChannelProvider(
            LanguageServiceSettings.defaultHttpJsonTransportProviderBuilder().build())
        .build()

See here for details.

It should be:

LanguageServiceSettings languageServiceSettings =
    LanguageServiceSettings.newHttpJsonBuilder().build();

Because the later sets a few more httpJson specific configs through here
@blakeli0 blakeli0 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 6, 2022
@blakeli0
Copy link
Collaborator Author

blakeli0 commented Nov 2, 2022

Fixed by #1077

@blakeli0 blakeli0 closed this as completed Nov 2, 2022
suztomo pushed a commit that referenced this issue Mar 21, 2023
@renovate-bot
deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…
158f890 
….6.14 (#1034)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:proto-google-iam-v1](https://github.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://github.com/googleapis/java-iam)) | `1.6.13` -> `1.6.14` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.14/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.14/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.14/compatibility-slim/1.6.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.14/confidence-slim/1.6.13)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.14`](https://github.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;1614-httpsgithubcomgoogleapisjava-iamcomparev1613v1614-2022-11-18)

[Compare Source](https://github.com/googleapis/java-iam/compare/v1.6.13...v1.6.14)

##### Dependencies

-   Update dependency com.google.cloud:google-iam-policy to v1.6.13 ([#&#8203;532](https://github.com/googleapis/java-iam/issues/532)) ([66c5b64](https://github.com/googleapis/java-iam/commit/66c5b64e8ad0457b5c9289ac75e581a6b25ca643))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNy4zIiwidXBkYXRlZEluVmVyIjoiMzQuMjcuMyJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blakeli0