Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(comment): autoconfig gen draft2 javadoc2 #1060

Merged
merged 7 commits into from
Nov 3, 2022
Merged

feat(comment): autoconfig gen draft2 javadoc2 #1060

merged 7 commits into from
Nov 3, 2022

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Oct 12, 2022 •
edited
Loading

Added javadoc comments to [Service]AutoConfig and [Service]Properties

@diegomarquezp diegomarquezp requested review from a team as code owners October 12, 2022 17:36
@diegomarquezp diegomarquezp force-pushed the autoconfig-gen-draft2-javadoc2 branch from f0ed046 to b966d6b Compare October 12, 2022 19:10
@diegomarquezp diegomarquezp changed the title [DRAFT] Autoconfig gen draft2 javadoc2 Autoconfig gen draft2 javadoc2 Oct 12, 2022
@diegomarquezp diegomarquezp changed the title Autoconfig gen draft2 javadoc2 feat(comment): autoconfig gen draft2 javadoc2 Oct 12, 2022
@zhumin8 zhumin8 added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Oct 13, 2022
zhumin8
zhumin8 requested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my two-cents on some of the wording. (For some of them, I took the easy route and commented on the golden files instead.) It might also worth to go over the wording of these with the whole team in our meetings?

...n/java/com/google/api/generator/spring/composer/comment/SpringAutoconfigCommentComposer.java Outdated Show resolved Hide resolved
...n/java/com/google/api/generator/spring/composer/comment/SpringAutoconfigCommentComposer.java Outdated Show resolved Hide resolved
...n/java/com/google/api/generator/spring/composer/comment/SpringPropertiesCommentComposer.java Outdated Show resolved Hide resolved
...est/java/com/google/api/generator/spring/composer/goldens/EchoSpringAutoConfiguration.golden Outdated Show resolved Hide resolved
...est/java/com/google/api/generator/spring/composer/goldens/EchoSpringAutoConfiguration.golden Outdated Show resolved Hide resolved
src/main/java/com/google/api/generator/spring/composer/comment/CommentComposer.java Outdated Show resolved Hide resolved
@diegomarquezp diegomarquezp force-pushed the autoconfig-gen-draft2-javadoc2 branch 2 times, most recently from ab15c44 to 39a243d Compare October 23, 2022 00:28
zhumin8
zhumin8 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zhumin8 and others added 6 commits November 2, 2022 20:21
@zhumin8 @diegomarquezp
feat(SpringGen): adding extra annotations at the SpringComposer ste…
f075bae 
…p for all Spring classes generated (#1062)

this pr:
- adds a @BetaApi annotation for each class composed in SpringComposer
- also moves the @generated("by gapic-generator-java") annotation to SpringComposer for consistency. (this annotation was missing for the properties class composer.)
- Updating annotations in SpringComposer level for the ones that applies to all classes makes it easier for future changes when needed.
@diegomarquezp
fix(test): remove wrong files from rebase action
32bb327
@diegomarquezp
fix(format): linting
a6b0fd3
@diegomarquezp
fix(license): add license header to prop comm comp
0e43c97
@diegomarquezp
fix(test): restore ComposerTest
03a5fe3
@diegomarquezp
fix: format files
ea84a81
@diegomarquezp diegomarquezp force-pushed the autoconfig-gen-draft2-javadoc2 branch from adb457b to ea84a81 Compare November 2, 2022 20:25
@diegomarquezp
Copy link
Contributor Author

Force pushed a rebase

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

95.5% 95.5% Coverage
0.0% 0.0% Duplication

@diegomarquezp diegomarquezp merged commit 38459cc into autoconfig-gen-draft2 Nov 3, 2022
@diegomarquezp diegomarquezp deleted the autoconfig-gen-draft2-javadoc2 branch November 3, 2022 20:22
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot
deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…
216aaa7 
….6.23 (#1060)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:proto-google-iam-v1](https://github.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://github.com/googleapis/java-iam)) | `1.6.22` -> `1.6.23` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.23/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.23/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.23/compatibility-slim/1.6.22)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.23/confidence-slim/1.6.22)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.23`](https://github.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;1623-httpsgithubcomgoogleapisjava-iamcomparev1622v1623-2022-12-20)

[Compare Source](https://github.com/googleapis/java-iam/compare/v1.6.22...v1.6.23)

##### Dependencies

-   Update dependency com.google.api:api-common to v2.3.1 ([#&#8203;567](https://github.com/googleapis/java-iam/issues/567)) ([17e62e8](https://github.com/googleapis/java-iam/commit/17e62e80f0ea8c2d4edfe6bb16ef5ee7acbc22f3))
-   Update dependency com.google.auth:google-auth-library-oauth2-http to v1.14.0 ([#&#8203;571](https://github.com/googleapis/java-iam/issues/571)) ([9c48311](https://github.com/googleapis/java-iam/commit/9c48311fbac25f9c9545f3404a42cdadf8ebb243))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#&#8203;565](https://github.com/googleapis/java-iam/issues/565)) ([32be2fb](https://github.com/googleapis/java-iam/commit/32be2fb0cfafa3681489c18e367cf12f22c567d3))
-   Update dependency com.google.cloud:google-iam-policy to v1.6.22 ([#&#8203;560](https://github.com/googleapis/java-iam/issues/560)) ([de39d89](https://github.com/googleapis/java-iam/commit/de39d89c08c9e45bc977ea393570a8d01cf48af2))
-   Update dependency com.google.protobuf:protobuf-bom to v3.21.12 ([#&#8203;563](https://github.com/googleapis/java-iam/issues/563)) ([607e260](https://github.com/googleapis/java-iam/commit/607e2601b71ff1fb51406e6c97dd79208296f404))
-   Update dependency com.google.protobuf:protobuf-java to v3.21.12 ([#&#8203;564](https://github.com/googleapis/java-iam/issues/564)) ([4b2b26b](https://github.com/googleapis/java-iam/commit/4b2b26bd29d88ccb602a71225d6e2decb49b9649))
-   Update dependency io.grpc:grpc-protobuf to v1.51.1 ([#&#8203;573](https://github.com/googleapis/java-iam/issues/573)) ([2143ec8](https://github.com/googleapis/java-iam/commit/2143ec8a90dbcdb128dffea9777fa9d183c3068e))
-   Update dependency io.grpc:grpc-stub to v1.51.1 ([#&#8203;574](https://github.com/googleapis/java-iam/issues/574)) ([488496a](https://github.com/googleapis/java-iam/commit/488496aa09c9d976bf0c450fb8584f07e7c74c03))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmileaf emmileaf emmileaf left review comments

@zhumin8 zhumin8 zhumin8 approved these changes

Assignees
No one assigned
Labels
spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegomarquezp @zhumin8 @emmileaf