Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spring): use parsed api shortname as libname #1084

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Nov 4, 2022

Follow-up PR to switch getLibName() to use apiShortName parsed from default host.

  • Added an extra conversion for showcase (which we unit test with), which uses localhost:7469 and does not parse to a pretty libname. (This means the current spring golden tests don't really cover other cases of getLibName(), but the logic itself also lives upstream)

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Nov 4, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@emmileaf emmileaf added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Nov 4, 2022
@emmileaf emmileaf marked this pull request as ready for review November 4, 2022 18:32
@emmileaf emmileaf requested review from a team as code owners November 4, 2022 18:32
@zhumin8
Copy link
Contributor

zhumin8 commented Nov 7, 2022

I wonder if we should just stick to localhost:7469 for showcase and update our expected test resutls instead? Judging from this test in #1075, localhost:7469 is the expected api-shortname. We could alternatively alter out test setup, but as you said, that would be unnecessary since it's testing upstream logic.

@emmileaf
Copy link
Contributor Author

emmileaf commented Nov 7, 2022

@zhumin8 Hmm yeah, keeping it that way and updating our goldens also makes sense given this is expected upstream logic. Will update!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@emmileaf emmileaf merged commit 5f637cc into autoconfig-gen-draft2 Nov 9, 2022
@emmileaf emmileaf deleted the update-libname-spring branch November 9, 2022 14:09
suztomo pushed a commit that referenced this pull request Mar 21, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api:gax-bom](https://github.com/googleapis/java-shared-config) ([source](https://github.com/googleapis/gax-java)) | `2.21.0` -> `2.22.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api:gax-bom/2.22.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api:gax-bom/2.22.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api:gax-bom/2.22.0/compatibility-slim/2.21.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api:gax-bom/2.22.0/confidence-slim/2.21.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45Ny42IiwidXBkYXRlZEluVmVyIjoiMzQuOTcuNiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants