Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add HttpJson Showcase test for Location Mixins #1656

Merged
merged 9 commits into from
Apr 28, 2023
Merged

chore: Add HttpJson Showcase test for Location Mixins #1656

merged 9 commits into from
Apr 28, 2023

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Apr 26, 2023 •
edited
Loading

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Part of #1439 ☕️

Update to showcase v0.27.0 is to incorporate this fix: googleapis/gapic-showcase#1299

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 26, 2023
@lqiu96 lqiu96 mentioned this pull request Apr 26, 2023
Closed
27 tasks
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 marked this pull request as ready for review April 26, 2023 21:19
@lqiu96 lqiu96 requested a review from a team as a code owner April 26, 2023 21:19
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2023
@burkedavison
Copy link
Member

LGTM. Looking for approval from @blakeli0

burkedavison
burkedavison reviewed Apr 27, 2023
View reviewed changes
.github/workflows/sonar.yaml
@@ -1,6 +1,6 @@
name: SonarCloud Build
env:
SHOWCASE_VERSION: 0.26.1
SHOWCASE_VERSION: 0.27.0
Copy link
Member

@burkedavison burkedavison Apr 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Five version update locations. Oof. We should find a way to refactor this to reduce the chance we miss one in the future.

Edit: To be clear, not requesting this change in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed. Created an issue about automating the showcase version (#1601), but also worth looking into refactoring so that the version is managed in one place.

blakeli0
blakeli0 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lqiu96 lqiu96 merged commit 6672a50 into main Apr 28, 2023
@lqiu96 lqiu96 deleted the main-showcase_location_mixin branch April 28, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison left review comments

@blakeli0 blakeli0 blakeli0 approved these changes

@mpeddada1 mpeddada1 Awaiting requested review from mpeddada1

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HttpJson Mixins RPCs (Locations & IAM) Not Supported
4 participants
@lqiu96 @burkedavison @blakeli0 @mpeddada1