Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [iam] upgrading Protobuf to 23.1 and gRPC to 1.55.0 in code generation #1693

Merged
merged 7 commits into from
May 24, 2023
Merged

chore: [iam] upgrading Protobuf to 23.1 and gRPC to 1.55.0 in code generation #1693

merged 7 commits into from
May 24, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented May 22, 2023 •
edited
Loading

  • Regenerate this pull request now.

PiperOrigin-RevId: 534084593

Source-Link: googleapis/googleapis@aa4559a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/370325af8236732f5885f5940e0ef481fee83003
Copy-Tag: eyJwIjoiamF2YS1pYW0vLk93bEJvdC55YW1sIiwiaCI6IjM3MDMyNWFmODIzNjczMmY1ODg1ZjU5NDBlMGVmNDgxZmVlODMwMDMifQ==

@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner May 22, 2023 18:50
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 22, 2023
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label May 22, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2023
@mpeddada1
Copy link
Contributor

Need to merge this PR in first: #1698

@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented May 23, 2023

Owl bot is regenerating pull request 1693...
Build name: YzU2Zjc2YTEtMDMwNy00OGY4LTgxM2QtMTY2MDliZmJjZTBj

@gcf-owl-bot
chore: upgrading Protobuf to 23.1 and gRPC to 1.55.0 in code generation
e12f449 
PiperOrigin-RevId: 534084593

Source-Link: googleapis/googleapis@aa4559a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/370325af8236732f5885f5940e0ef481fee83003
Copy-Tag: eyJwIjoiamF2YS1pYW0vLk93bEJvdC55YW1sIiwiaCI6IjM3MDMyNWFmODIzNjczMmY1ODg1ZjU5NDBlMGVmNDgxZmVlODMwMDMifQ==
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-iam branch from 5df53cf to e12f449 Compare May 23, 2023 17:43
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@mpeddada1
Copy link
Contributor

mpeddada1 commented May 23, 2023 •
edited
Loading

Stacktrace from ci / build(8):

Error:  7002: com.google.iam.v1.TestIamPermissionsResponse$Builder: Method 'public com.google.iam.v1.TestIamPermissionsResponse$Builder clearOneof(com.google.protobuf.Descriptors$OneofDescriptor)' has been removed
Error:  7002: com.google.iam.v1.TestIamPermissionsResponse$Builder: Method 'public com.google.iam.v1.TestIamPermissionsResponse$Builder clone()' has been removed
Error:  7002: com.google.iam.v1.TestIamPermissionsResponse$Builder: Method 'public com.google.iam.v1.TestIamPermissionsResponse$Builder setField(com.google.protobuf.Descriptors$FieldDescriptor, java.lang.Object)' has been removed
Error:  7002: com.google.iam.v1.TestIamPermissionsResponse$Builder: Method 'public com.google.iam.v1.TestIamPermissionsResponse$Builder setRepeatedField(com.google.protobuf.Descriptors$FieldDescriptor, int, java.lang.Object)' has been removed

Even though protobuf 3.23.1 and 1.55.1 are brought in.
Screenshot 2023-05-23 at 1 52 13 PM

@suztomo
Copy link
Member

suztomo commented May 23, 2023

Pasted all errors http://gpaste/6136580984012800

@mpeddada1
Copy link
Contributor

The methods being removed are expected to rely on the parent class directly. As an example, confirmed that methods that were removed in AuditConfigDelta are indeed defined in the parent class, GeneratedMessageV3.

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@mpeddada1
Copy link
Contributor

@suztomo I've added exclusions to https://github.com/googleapis/sdk-platform-java/blob/main/java-iam/proto-google-iam-v1/clirr-ignored-differences.xml to get past the failures. Could I get a review on this please?

@mpeddada1 mpeddada1 requested a review from suztomo May 23, 2023 22:12
@sonarqubecloud
Copy link

[gapic-generator-java-root] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 46 Code Smells

0.0% 0.0% Coverage
62.8% 62.8% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@suztomo suztomo merged commit ff3c154 into main May 24, 2023
@suztomo suztomo deleted the owl-bot-copy-java-iam branch May 24, 2023 02:10
mpeddada1 added a commit that referenced this pull request May 25, 2023
@mpeddada1
Revert "chore: [iam] upgrading Protobuf to 23.1 and gRPC to 1.55.0 in…
0a13a3c 
… code generation (#1693)"

This reverts commit ff3c154.
@mpeddada1 mpeddada1 mentioned this pull request May 25, 2023
Merged
mpeddada1 added a commit that referenced this pull request May 25, 2023
@mpeddada1
Revert "chore: [iam] upgrading Protobuf to 23.1 and gRPC to 1.55.0 in…
642969d 
… code generation (#1693)" (#1714)

This reverts commit ff3c154.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpeddada1 @suztomo