Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Regenerate golden files with downgraded protobuf (3.21.12) and grpc (1.54.0) versions #1715

Merged
merged 1 commit into from
May 25, 2023

Conversation

mpeddada1
Copy link
Contributor

Partially reverts changes in #1698

Runtime versions protobuf and grpc should still be 3.23.1 and grpc 1.55.1

@mpeddada1 mpeddada1 requested a review from a team as a code owner May 25, 2023 21:02
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label May 25, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 114 Code Smells

0.0% 0.0% Coverage
75.2% 75.2% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 114 Code Smells

0.0% 0.0% Coverage
77.0% 77.0% Duplication

@mpeddada1 mpeddada1 added the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2023
@sonarqubecloud
Copy link

[java_showcase_unit_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 114 Code Smells

0.0% 0.0% Coverage
77.0% 77.0% Duplication

@mpeddada1 mpeddada1 merged commit d545964 into main May 25, 2023
@mpeddada1 mpeddada1 deleted the revert-golden-test-updates branch May 25, 2023 21:33
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants