Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove -H:-RunReachabilityHandlersConcurrently #1892

Merged
merged 2 commits into from
Sep 6, 2023
Merged

fix: remove -H:-RunReachabilityHandlersConcurrently #1892

merged 2 commits into from
Sep 6, 2023

Conversation

burkedavison
Copy link
Member

GraalVM flag -H:-RunReachabilityHandlersConcurrently is removed, relying instead on static reflect-config.json configs defined in each client library.

Related: googleapis/gax-java#1815

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 31, 2023
@burkedavison burkedavison added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@burkedavison burkedavison marked this pull request as ready for review August 29, 2023 18:57
@burkedavison burkedavison requested a review from a team as a code owner August 29, 2023 18:58
@burkedavison burkedavison removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 29, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Aug 29, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mpeddada1 mpeddada1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2023
@mpeddada1 mpeddada1 merged commit 9cc52e1 into main Sep 6, 2023
@mpeddada1 mpeddada1 deleted the remove-runreachabilityhandlersconcurrently branch September 6, 2023 18:28
@release-please release-please bot mentioned this pull request Sep 6, 2023
Merged
@mpeddada1 mpeddada1 mentioned this pull request Sep 7, 2023
Closed
@mpeddada1 mpeddada1 mentioned this pull request Sep 21, 2023
Closed
@zhumin8 zhumin8 mentioned this pull request Sep 27, 2023
Closed
@zakkak zakkak mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burkedavison @mpeddada1