chore: Use Java Auth Library's GDU constant #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on: #2341 to bump in the |
product-auto-label
bot
added
size: l
lqiu96
force-pushed
the
use-credentials-GDU-constant
branch
from
e103591 to
cbe3707
Compare
product-auto-label
bot
added
size: s
|
|
blakeli0
reviewed
Jan 5, 2024
| @@ -200,7 +200,7 @@ private String determineEndpoint() throws IOException { | |||
|
|
|||
| // Check if mTLS is configured with non-GDU | |||
| if (endpoint.equals(mtlsEndpoint()) | |||
| && !resolvedUniverseDomain().equals(GOOGLE_DEFAULT_UNIVERSE)) { | |||
| && !resolvedUniverseDomain().equals(Credentials.GOOGLE_DEFAULT_UNIVERSE)) { | |||
There was a problem hiding this comment.
I might missed this in earlier PRs, since we only set resolvedUniverseDomain later, resolvedUniverseDomain() is always null here?
There was a problem hiding this comment.
Never mind, resolvedUniverseDomain was already set in previous steps. It's still good to move Credentials.GOOGLE_DEFAULT_UNIVERSE to the left of the equals method though.
blakeli0
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.