Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generation config comparator #2587

Merged
merged 25 commits into from
Mar 21, 2024
Merged

feat: add generation config comparator #2587

merged 25 commits into from
Mar 21, 2024

Commits on Mar 15, 2024

  1. feat: add a generation config comparator

    @JoeWang1127
    JoeWang1127 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7f91d91 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. compare library configs

    @JoeWang1127
    JoeWang1127 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    e5aae8e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/config-comparator

    @JoeWang1127
    JoeWang1127 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    7110bb3 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. code refactor

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    7cb2e97 View commit details
    Browse the repository at this point in the history

  2. add proto_path removal or addition change

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    a8b1b26 View commit details
    Browse the repository at this point in the history

  3. change to HashLibrary

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    218e431 View commit details
    Browse the repository at this point in the history

  4. use object, rather than file path in comparator interface

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    15e0db7 View commit details
    Browse the repository at this point in the history

  5. add unit tests

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    b876354 View commit details
    Browse the repository at this point in the history

  6. add setUp method in ut

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    5348539 View commit details
    Browse the repository at this point in the history

  7. add unit tests against repo level changes

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    8e6b1c1 View commit details
    Browse the repository at this point in the history

  8. add unit tests against library parameters

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    4f0f2c1 View commit details
    Browse the repository at this point in the history

  9. add unit tests against versioned proto_path

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    e8b2d6b View commit details
    Browse the repository at this point in the history

  10. restore gapic_config

    @JoeWang1127
    JoeWang1127 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    e5f7a5e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. add comments

    @JoeWang1127
    JoeWang1127 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2d6b13b View commit details
    Browse the repository at this point in the history

  2. code refactor

    @JoeWang1127
    JoeWang1127 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2dc41b3 View commit details
    Browse the repository at this point in the history

  3. change type

    @JoeWang1127
    JoeWang1127 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6fba2ad View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. change enum types

    @JoeWang1127
    JoeWang1127 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    cda24a1 View commit details
    Browse the repository at this point in the history

  2. move get_library_name method to LibraryConfig

    @JoeWang1127
    JoeWang1127 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    af85a4f View commit details
    Browse the repository at this point in the history

  3. fix integration tests

    @JoeWang1127
    JoeWang1127 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    989da47 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/config-comparator

    @JoeWang1127
    JoeWang1127 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    d3df205 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. comment out library removal and gapic removal type

    @JoeWang1127
    JoeWang1127 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    376015d View commit details
    Browse the repository at this point in the history

  2. raise an error if api_shortname is changed but library_name remains t… 

    …he same
    @JoeWang1127
    JoeWang1127 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    70e0fe8 View commit details
    Browse the repository at this point in the history

  3. use built-in method, vars, to list parameters of an object

    @JoeWang1127
    JoeWang1127 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    42b5b03 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/config-comparator

    @JoeWang1127
    JoeWang1127 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4890786 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feat/config-comparator

    @JoeWang1127
    JoeWang1127 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    33b8c47 View commit details
    Browse the repository at this point in the history