chore: make generator version an optional param #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
blakeli0
approved these changes
Jul 23, 2024
| @@ -104,6 +107,7 @@ docker run \ | |||
| -u "$(id -u):$(id -g)" \ | |||
| -v "$(pwd):${workspace_name}" \ | |||
| -v "$HOME"/.m2:/home/.m2 \ | |||
| -e generator_version="${generator_version}" \ | |||
There was a problem hiding this comment.
From our shell style guide: Constants and anything exported to the environment should be capitalized, separated with underscores, and declared at the top of the file.
The top of the file part doesn't apply, but I think it's reasonable to make it uppercase for consistency with other env vars we set up in the Dockerfile
There was a problem hiding this comment.
Makes sense, do you mind updating it in the absence of Joe?
diegomarquezp
approved these changes
Jul 25, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
gapic_generator_versionas an optional parameter.gapic_generator_versionthrough environment variable if it's not specified in the generation config.