Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ggj][codegen][test] feat: add ServiceClientTest.rpcTest for unary and LRO methods #351

Merged
merged 11 commits into from
Sep 26, 2020
Merged

[ggj][codegen][test] feat: add ServiceClientTest.rpcTest for unary and LRO methods #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e4f7374
fix!: refactor field into MethodArgument, add enum/msg flags
miraleung Sep 22, 2020
6489625
feat: partial isAssignableFrom VaporRef support, enable full-name typ…
miraleung Sep 23, 2020
fb565b6
feat: support negative numeric literals
miraleung Sep 24, 2020
a438128
fix: separate resname tokenizing from class composer
miraleung Sep 24, 2020
396a0cc
feat: add per-type default value composer
miraleung Sep 24, 2020
18cb9bd
feat: add ServiceClientTest.methodExceptionTests codegen
miraleung Sep 24, 2020
f45c475
feat: add rpcExceptionTest for RPCs w/o overloads, support LRO
miraleung Sep 24, 2020
8a87e3a
feat: ServiceClientTest.rpcExceptionTest support for LRO, streaming
miraleung Sep 25, 2020
2087c80
fix: sorted method args
miraleung Sep 25, 2020
78d220e
feat: add ServiceClientTest.rpcTest for unary and LRO methods
miraleung Sep 25, 2020
ba6d41c
Merge branch 'master' into gp/g8
miraleung Sep 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions src/main/java/com/google/api/generator/gapic/composer/DefaultValueComposer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,16 @@
import com.google.api.generator.engine.ast.StringObjectValue;
import com.google.api.generator.engine.ast.TypeNode;
import com.google.api.generator.engine.ast.ValueExpr;
import com.google.api.generator.engine.ast.VariableExpr;
import com.google.api.generator.gapic.model.Field;
import com.google.api.generator.gapic.model.Message;
import com.google.api.generator.gapic.model.MethodArgument;
import com.google.api.generator.gapic.model.ResourceName;
import com.google.api.generator.gapic.utils.JavaStyle;
import com.google.api.generator.gapic.utils.ResourceNameConstants;
import com.google.common.base.Preconditions;
import com.google.longrunning.Operation;
import com.google.protobuf.Any;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
Expand All @@ -38,6 +41,10 @@
import java.util.stream.Collectors;

public class DefaultValueComposer {
private static TypeNode OPERATION_TYPE =
TypeNode.withReference(ConcreteReference.withClazz(Operation.class));
private static TypeNode ANY_TYPE = TypeNode.withReference(ConcreteReference.withClazz(Any.class));

static Expr createDefaultValue(
MethodArgument methodArg, Map<String, ResourceName> resourceNames) {
if (methodArg.isResourceNameHelper()) {
Expand Down Expand Up @@ -237,4 +244,42 @@ static Expr createSimpleMessageBuilderExpr(
.setReturnType(message.type())
.build();
}

static Expr createSimpleOperationBuilderExpr(String name, VariableExpr responseExpr) {
Expr operationExpr =
MethodInvocationExpr.builder()
.setStaticReferenceType(OPERATION_TYPE)
.setMethodName("newBuilder")
.build();
operationExpr =
MethodInvocationExpr.builder()
.setExprReferenceExpr(operationExpr)
.setMethodName("setName")
.setArguments(ValueExpr.withValue(StringObjectValue.withValue(name)))
.build();
operationExpr =
MethodInvocationExpr.builder()
.setExprReferenceExpr(operationExpr)
.setMethodName("setDone")
.setArguments(
ValueExpr.withValue(
PrimitiveValue.builder().setType(TypeNode.BOOLEAN).setValue("true").build()))
.build();
operationExpr =
MethodInvocationExpr.builder()
.setExprReferenceExpr(operationExpr)
.setMethodName("setResponse")
.setArguments(
MethodInvocationExpr.builder()
.setStaticReferenceType(ANY_TYPE)
.setMethodName("pack")
.setArguments(responseExpr)
.build())
.build();
return MethodInvocationExpr.builder()
.setExprReferenceExpr(operationExpr)
.setMethodName("build")
.setReturnType(OPERATION_TYPE)
.build();
}
}
Loading