[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API #396

xiaozhenliu-gg5 · 2020-10-21T18:23:11Z

Find more details in design doc: go/java-micro-integration-test-infra

run the command for updating goldens files if the integration test fails:

>> bezel run //test/integration:redis_update
Target //test/integration:redis_update up-to-date:
  bazel-bin/test/integration/redis_update.zip
  bazel-bin/test/integration/redis_update.sh
INFO: Elapsed time: 5.290s, Critical Path: 0.61s
INFO: 2 processes: 1 internal, 1 linux-sandbox.
INFO: Build completed successfully, 2 total actions
INFO: Build completed successfully, 2 total actions
Archive:  bazel-out/k8-fastbuild/bin/test/integration/redis_update.zip
  inflating: test/integration/goldens/redis/CloudRedisClientTest.java  [text]  
  inflating: test/integration/goldens/redis/GrpcCloudRedisCallableFactory.java  [text]  
  inflating: test/integration/goldens/redis/CloudRedisStub.java  [text]  
  inflating: test/integration/goldens/redis/MockCloudRedisImpl.java  [text]  
  inflating: test/integration/goldens/redis/InstanceName.java  [text]  
  inflating: test/integration/goldens/redis/CloudRedisClient.java  [text]  
  inflating: test/integration/goldens/redis/LocationName.java  [text]  
  inflating: test/integration/goldens/redis/MockCloudRedis.java  [text]  
  inflating: test/integration/goldens/redis/GrpcCloudRedisStub.java  [text]  
  inflating: test/integration/goldens/redis/CloudRedisStubSettings.java  [text]  
  inflating: test/integration/goldens/redis/CloudRedisSettings.java  [text]

miraleung

Does this need to be merged to master? Or are the large diffs new changes?

Will review post-merge.

xiaozhenliu-gg5 · 2020-10-23T22:22:47Z

The diffs are new, and many of them is similar to integration_test rule because they both have the code generation part. But the similar snippet cannot be extracted to a separate macro, because we want bazel run goldens_update to be directly run without bazel build. So the code generation should be part of this rule, similar as file-diff rule.

…396) * goldens update bazel rules * clean up

…_scopes annotation (#419) * fix: support non-name fields with res-refs in resname def parsing * fix: add workaround for missing default_host and oauth_scopes annotation * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens Co-authored-by: Xiaozhen Liu <xiaozhenliu@google.com>

* fix: support non-name fields with res-refs in resname def parsing * fix: add workaround for missing default_host and oauth_scopes annotation * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * fix: clarify LRO parsing error messages Co-authored-by: Xiaozhen Liu <xiaozhenliu@google.com>

… message parsing (#421) * fix: support non-name fields with res-refs in resname def parsing * fix: add workaround for missing default_host and oauth_scopes annotation * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * fix: clarify LRO parsing error messages * feat: support deeply-nested types in AST and proto message parsing Co-authored-by: Xiaozhen Liu <xiaozhenliu@google.com>

…bcomponents (#422) * fix: support non-name fields with res-refs in resname def parsing * fix: add workaround for missing default_host and oauth_scopes annotation * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * fix: clarify LRO parsing error messages * feat: support deeply-nested types in AST and proto message parsing * fix: prevent resname tokens from matching subcomponents Co-authored-by: Xiaozhen Liu <xiaozhenliu@google.com>

* fix: support non-name fields with res-refs in resname def parsing * fix: add workaround for missing default_host and oauth_scopes annotation * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * fix: clarify LRO parsing error messages * feat: support deeply-nested types in AST and proto message parsing * fix: prevent resname tokens from matching subcomponents * fix: use TypeParser for proto message parsing * fix: merge master Co-authored-by: Xiaozhen Liu <xiaozhenliu@google.com>

…ceClientTest (#431) * fix: support non-name fields with res-refs in resname def parsing * fix: add workaround for missing default_host and oauth_scopes annotation * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * fix: clarify LRO parsing error messages * feat: support deeply-nested types in AST and proto message parsing * fix: prevent resname tokens from matching subcomponents * fix: use TypeParser for proto message parsing * fix: merge master * fix: use generic types in field instantiation in ServiceClientTest Co-authored-by: Xiaozhen Liu <xiaozhenliu@google.com>

…e parsing (#426) * fix: support non-name fields with res-refs in resname def parsing * fix: add workaround for missing default_host and oauth_scopes annotation * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * fix: clarify LRO parsing error messages * feat: support deeply-nested types in AST and proto message parsing * fix: prevent resname tokens from matching subcomponents * fix: use TypeParser for proto message parsing * fix: merge master * fix: use generic types in field instantiation in ServiceClientTest * fix: prevent descension into map types in nested message parsing * fix: merge master * fix: merge master * fix: merge master * fix: merge master Co-authored-by: Xiaozhen Liu <xiaozhenliu@google.com>

…436) * fix: support non-name fields with res-refs in resname def parsing * fix: add workaround for missing default_host and oauth_scopes annotation * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * fix: clarify LRO parsing error messages * feat: support deeply-nested types in AST and proto message parsing * fix: prevent resname tokens from matching subcomponents * fix: use TypeParser for proto message parsing * fix: merge master * fix: use generic types in field instantiation in ServiceClientTest * fix: prevent descension into map types in nested message parsing * fix: merge master * fix: merge master * fix: merge master * fix: merge master * fix: prevent descension into map types in nested message parsing * build: add logging, redis gradle assembly rules * fix: merge master Co-authored-by: Xiaozhen Liu <xiaozhenliu@google.com>

#428) * fix: support non-name fields with res-refs in resname def parsing * fix: add workaround for missing default_host and oauth_scopes annotation * fix: clarify LRO parsing error messages * feat: support deeply-nested types in AST and proto message parsing * fix: prevent resname tokens from matching subcomponents * fix: use TypeParser for proto message parsing * fix: use generic types in field instantiation in ServiceClientTest * fix: prevent descension into map types in nested message parsing * fix: merge master * fix: use both map generics in ServiceClientTest codegen * fix: add workaround for missing default_host and oauth_scopes annotation * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * [ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#396) * goldens update bazel rules * clean up * [ggj][infra][4/5]feat: add goldens update bazel rules for Asset API (#397) * goldens update bazel rules * clean up * goldens update rule for asset API * update goldens * fix: clarify LRO parsing error messages * feat: support deeply-nested types in AST and proto message parsing * fix: prevent resname tokens from matching subcomponents * fix: use TypeParser for proto message parsing * fix: merge master * fix: use generic types in field instantiation in ServiceClientTest * fix: prevent descension into map types in nested message parsing * fix: merge master * fix: merge master * fix: merge master * fix: merge master * fix: prevent descension into map types in nested message parsing * build: add logging, redis gradle assembly rules * fix: merge master Co-authored-by: Xiaozhen Liu <xiaozhenliu@google.com>

…onfig to v1.5.2 (#396) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://github.com/googleapis/java-shared-config) | `1.5.1` -> `1.5.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.2/compatibility-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.2/confidence-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.2`](https://github.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#152-httpsgithubcomgoogleapisjava-shared-configcomparev151v152-2022-07-25) [Compare Source](https://github.com/googleapis/java-shared-config/compare/v1.5.1...v1.5.2) ##### Dependencies - update dependency com.puppycrawl.tools:checkstyle to v10 ([#435](https://github.com/googleapis/java-shared-config/issues/435)) ([bfc8ce1](https://github.com/googleapis/java-shared-config/commit/bfc8ce1deca6292147d002d3afe22a09840aa5d6)) - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.13 ([#488](https://github.com/googleapis/java-shared-config/issues/488)) ([39b91ee](https://github.com/googleapis/java-shared-config/commit/39b91ee1283f0a5fbbe63e8bfd1ec97ab4ab377e)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.13 ([#489](https://github.com/googleapis/java-shared-config/issues/489)) ([cc3bcfa](https://github.com/googleapis/java-shared-config/commit/cc3bcfa2d6717441a8d5b5048fa78c2cf7aabf2b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-common-protos).

…urcemanager to v3-rev20220710-2.0.0 (#396) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.apis:google-api-services-cloudresourcemanager](http://nexus.sonatype.org/oss-repository-hosting.html) ([source](http://svn.sonatype.org/spice/tags/oss-parent-7)) | `v3-rev20220710-1.32.1` -> `v3-rev20220710-2.0.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.apis:google-api-services-cloudresourcemanager/v3-rev20220710-2.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.apis:google-api-services-cloudresourcemanager/v3-rev20220710-2.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.apis:google-api-services-cloudresourcemanager/v3-rev20220710-2.0.0/compatibility-slim/v3-rev20220710-1.32.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.apis:google-api-services-cloudresourcemanager/v3-rev20220710-2.0.0/confidence-slim/v3-rev20220710-1.32.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).

🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [1.94.3](https://www.github.com/googleapis/java-core/compare/v1.94.2...v1.94.3) (2021-03-02) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.31.3 ([#394](https://www.github.com/googleapis/java-core/issues/394)) ([618d4c9](https://www.github.com/googleapis/java-core/commit/618d4c97c18fd249e74222a0a41fa0a9fa82034d)) * update dependency com.google.auth:google-auth-library-bom to v0.24.1 ([#390](https://www.github.com/googleapis/java-core/issues/390)) ([a4444d2](https://www.github.com/googleapis/java-core/commit/a4444d2671febe30007c81893e96cbbfda856e6f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

goldens update bazel rules

7591164

xiaozhenliu-gg5 requested review from miraleung and summer-ji-eng as code owners October 21, 2020 18:23

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2020

clean up

cee013e

xiaozhenliu-gg5 mentioned this pull request Oct 21, 2020

[ggj][infra][4/5]feat: add goldens update bazel rules for Asset API #397

Merged

miraleung suggested changes Oct 23, 2020

View reviewed changes

Merge branch 'master' into update-goldens

6a5253a

xiaozhenliu-gg5 requested a review from miraleung October 23, 2020 22:22

xiaozhenliu-gg5 added 2 commits October 23, 2020 17:04

Merge branch 'master' into update-goldens

49ed5a5

Merge branch 'master' into update-goldens

2c6be68

miraleung approved these changes Oct 26, 2020

View reviewed changes

xiaozhenliu-gg5 merged commit b26117b into master Oct 26, 2020

xiaozhenliu-gg5 deleted the update-goldens branch October 26, 2020 22:44

miraleung pushed a commit that referenced this pull request Oct 29, 2020

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#…

14d4960

…396) * goldens update bazel rules * clean up

miraleung pushed a commit that referenced this pull request Oct 30, 2020

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#…

5100131

…396) * goldens update bazel rules * clean up

miraleung pushed a commit that referenced this pull request Oct 30, 2020

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#…

86efcd1

…396) * goldens update bazel rules * clean up

miraleung pushed a commit that referenced this pull request Oct 30, 2020

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#…

abebd63

…396) * goldens update bazel rules * clean up

miraleung pushed a commit that referenced this pull request Oct 30, 2020

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#…

8f906fa

…396) * goldens update bazel rules * clean up

miraleung pushed a commit that referenced this pull request Oct 30, 2020

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API (#…

9cd2c89

…396) * goldens update bazel rules * clean up

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API #396

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API #396

xiaozhenliu-gg5 commented Oct 21, 2020

miraleung left a comment

xiaozhenliu-gg5 commented Oct 23, 2020

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API #396

[ggj][infra][3/5]feat: add goldens update bazel rules for Redis API #396

Conversation

xiaozhenliu-gg5 commented Oct 21, 2020

miraleung left a comment

Choose a reason for hiding this comment

xiaozhenliu-gg5 commented Oct 23, 2020