Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ggj] fix(engx): Handle nulls with poll() in MockServiceImpl #693

Merged
merged 3 commits into from
Mar 13, 2021

Conversation

miraleung
Copy link
Contributor

Improves the error message for client library users, instead of the more obscure error that previously occurred. In addition, remove() does not handle the empty case, while poll() does.

Before this change, here's the error one would get if responses was empty and responses.remove() was invoked.

com.google.cloud.datastream.v1alpha1.DatastreamClientTest > listLocationsTest STANDARD_ERROR
    Mar 10, 2021 5:26:18 PM io.grpc.internal.SerializingExecutor run
    SEVERE: Exception while executing runnable io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed@4ecefb07
    java.util.NoSuchElementException
        at java.util.LinkedList.removeFirst(LinkedList.java:270)
        at java.util.LinkedList.remove(LinkedList.java:685)
        at com.google.cloud.location.MockLocationsImpl.listLocations(MockLocationsImpl.java:64)

@miraleung miraleung requested a review from a team as a code owner March 11, 2021 06:43
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2021
@miraleung miraleung requested a review from vam-google March 11, 2021 06:43
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #693 (84fe695) into master (edd7443) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   92.46%   92.47%           
=======================================
  Files         124      124           
  Lines       13344    13351    +7     
  Branches      952      952           
=======================================
+ Hits        12339    12346    +7     
  Misses        761      761           
  Partials      244      244           
Impacted Files Coverage Δ
...r/gapic/composer/MockServiceImplClassComposer.java 99.76% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd7443...84fe695. Read the comment docs.

@miraleung miraleung merged commit 3f531bd into master Mar 13, 2021
@miraleung miraleung deleted the fix/mock_service_impl branch March 13, 2021 00:14
suztomo pushed a commit that referenced this pull request Mar 21, 2023
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


## [2.11.0](googleapis/java-shared-dependencies@v2.10.0...v2.11.0) (2022-05-18)


### Features

* next release from main branch is 2.11.0 ([#674](googleapis/java-shared-dependencies#674)) ([323a20c](googleapis/java-shared-dependencies@323a20c))


### Dependencies

* update dependency com.fasterxml.jackson:jackson-bom to v2.13.3 ([#689](googleapis/java-shared-dependencies#689)) ([1bcea0e](googleapis/java-shared-dependencies@1bcea0e))
* update dependency com.google.api-client:google-api-client-bom to v1.34.1 ([#685](googleapis/java-shared-dependencies#685)) ([82ea316](googleapis/java-shared-dependencies@82ea316))
* update dependency com.google.api:api-common to v2.2.0 ([#690](googleapis/java-shared-dependencies#690)) ([d5e8571](googleapis/java-shared-dependencies@d5e8571))
* update dependency com.google.auth:google-auth-library-bom to v1.7.0 ([#691](googleapis/java-shared-dependencies#691)) ([067f7b9](googleapis/java-shared-dependencies@067f7b9))
* update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#672](googleapis/java-shared-dependencies#672)) ([11311c4](googleapis/java-shared-dependencies@11311c4))
* update dependency com.google.http-client:google-http-client-bom to v1.41.8 ([#684](googleapis/java-shared-dependencies#684)) ([5153a98](googleapis/java-shared-dependencies@5153a98))
* update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#678](googleapis/java-shared-dependencies#678)) ([3d3a224](googleapis/java-shared-dependencies@3d3a224))
* update dependency io.grpc:grpc-bom to v1.46.0 ([#680](googleapis/java-shared-dependencies#680)) ([00f5d4a](googleapis/java-shared-dependencies@00f5d4a))
* update dependency org.checkerframework:checker-qual to v3.22.0 ([#683](googleapis/java-shared-dependencies#683)) ([275a37e](googleapis/java-shared-dependencies@275a37e))
* update gax.version to v2.17.0 ([#687](googleapis/java-shared-dependencies#687)) ([4b65150](googleapis/java-shared-dependencies@4b65150))
* update gax.version to v2.18.0 ([#692](googleapis/java-shared-dependencies#692)) ([f18503f](googleapis/java-shared-dependencies@f18503f))
* update google.core.version to v2.6.1 ([#671](googleapis/java-shared-dependencies#671)) ([a1bb345](googleapis/java-shared-dependencies@a1bb345))
* update google.core.version to v2.7.0 ([#693](googleapis/java-shared-dependencies#693)) ([d3a6ece](googleapis/java-shared-dependencies@d3a6ece))
* update iam.version to v1.3.2 ([#673](googleapis/java-shared-dependencies#673)) ([9d01376](googleapis/java-shared-dependencies@9d01376))
* update iam.version to v1.3.3 ([#679](googleapis/java-shared-dependencies#679)) ([27ee2b3](googleapis/java-shared-dependencies@27ee2b3))
* update iam.version to v1.3.4 ([#686](googleapis/java-shared-dependencies#686)) ([b860caf](googleapis/java-shared-dependencies@b860caf))
* update opencensus.version to v0.31.1 ([#682](googleapis/java-shared-dependencies#682)) ([1d0832c](googleapis/java-shared-dependencies@1d0832c))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants