chore: rework build infrastructure #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
approved these changes
Jan 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #913 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 153 153
Lines 16046 16046
Branches 1166 1166
=======================================
Hits 14095 14095
Misses 1607 1607
Partials 344 344 Continue to review full report at Codecov.
|
|
Looks like googleapis/googleapis is referencing I'll have to look into that to resolve the issue. |
|
Turns out it's a trivial fix to remove unused code from googleapis/googleapis. However, there was a chicken-and-egg-like situation, so I ended up upgrading gax-java and gapic-generator-java in googleapis and removing the code after releasing gapic-generator-java. (internal change: 424868012) |
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
Source-Link: googleapis/synthtool@fbc8bfe Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e76136cc48f90aa19ba29cdfbd4002111467e44a1c9d905867d98dafafbd03bb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
repository_rules.bzlanddependencies.properties. CreatesPROPERTIES.bzlinstead (which was dynamically generated by the rule above previously) to make the whole process straightforward.The
dependencies.properties-pattern is used in other repos (includinggax-java). Its purpose is to avoid dependency versions going out of sync when compiling source between Bazel and Gradle. However, we don't have Gradle, and we won't enable building with two different build systems, so YAGNI.