Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing infrastructure to verify the output #44

Closed
dandhlee opened this issue Jun 17, 2021 · 0 comments · Fixed by #262
Closed

Improve testing infrastructure to verify the output #44

dandhlee opened this issue Jun 17, 2021 · 0 comments · Fixed by #262
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dandhlee
Copy link
Collaborator

dandhlee commented Jun 17, 2021

Googlers see b/206698957.

Is your feature request related to a problem? Please describe.
Currently the testing infrastructure using tox -e docs does not verify the output produced.

Describe the solution you'd like
Whether using nox, tox or other forms of testing tools, have the test verify the output as well so we're not making changes that would be a breaking change.

Describe alternatives you've considered
For now, we're okay to move on as-is to ensure that the generation runs. We should revisit this ASAP to verify the content it outputs.

Additional context
N/A

@dandhlee dandhlee added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 17, 2021
@dandhlee dandhlee self-assigned this Jun 17, 2021
@dandhlee dandhlee mentioned this issue Oct 31, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@dandhlee and others