feat: add subclasses to children and reference #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you open a pull request, note that this repository is forked from here.
Unless the issue you're trying to solve is unique to this specific repository,
please file an issue and/or send changes upstream to the original as well.
The function
insert_children_on_class
only cared about underlying class methods, attributes and properties, which left out subclasses of a class.To make that happen, search for the parent class by using
datam['module']
and see if there is a parent class that exists, then check that both types areclass
so we don't accidentally insert anything else when we retrieve classes fromapp.env.docfx_yaml_classes.get(datam[MODULE])
.When actually inserting the children, we separate whether it's class items we're looking for such as attributes, properties and methods, or if it is a subclass of a class with the nested if condition.
template update to this corresponding PR: googleapis/doc-templates#238
Fixes internally filed issue.