Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disambiguate after grouping by packages and versions #132

Merged
merged 1 commit into from
Sep 14, 2021
Merged

fix: disambiguate after grouping by packages and versions #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docfx_yaml/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,11 +1487,11 @@ def convert_module_to_package_if_needed(obj):
if len(pkg_toc_yaml) == 0 and len(app.env.markdown_pages) == 0:
raise RuntimeError("No documentation for this module.")

pkg_toc_yaml = group_by_package(pkg_toc_yaml)

# Perform additional disambiguation of the name
disambiguated_names = disambiguate_toc_name(pkg_toc_yaml)

pkg_toc_yaml = group_by_package(pkg_toc_yaml)

# Keeping uidname field carrys over onto the toc.yaml files, we need to
# be keep using them but don't need them in the actual file
pkg_toc_yaml_with_uid = copy.deepcopy(pkg_toc_yaml)
Expand Down