Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add short snippet for missing summary #73

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Conversation

dandhlee
Copy link
Collaborator

Before you open a pull request, note that this repository is forked from here.
Unless the issue you're trying to solve is unique to this specific repository,
please file an issue and/or send changes upstream to the original as well.


Mostly on index pages, there can be a lot of entries with missing content which makes it inconsistent with entries that has snippets added from the generator. There aren't any missing content that's lost somewhere through the plugin, therefore adding in a bit of short snippet for a brief introduction for each entry.

Updates internally filed issue.

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@dandhlee dandhlee requested review from tbpg and a team July 20, 2021 04:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2021
@dandhlee
Copy link
Collaborator Author

Adding in a short bit for index pages as well (for each client library).

@dandhlee dandhlee merged commit bb432e7 into master Jul 21, 2021
@dandhlee dandhlee deleted the add_short_summary branch July 21, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants