Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that synth PR regeneration may take up to 24 hours #978

Closed
busunkim96 opened this issue Mar 9, 2021 · 0 comments · Fixed by #981
Closed

Clarify that synth PR regeneration may take up to 24 hours #978

busunkim96 opened this issue Mar 9, 2021 · 0 comments · Fixed by #981
Assignees
@SurferJeffAtGoogle
Labels
type: docs Improvement to the documentation for an API.

Comments

@busunkim96
Copy link
Contributor

I've had a few folks ask why a synthtool PR hasn't been regenerated. With other bots like renovatebot or snippet bot, checking the box results in the PR being regenerated almost immediately.

I think it would be helpful to add a disclaimer that it can take up to a day for the PR to be updated
image
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 10, 2021
@busunkim96 busunkim96 added type: docs Improvement to the documentation for an API. and removed triage me I really want to be triaged. labels Mar 10, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle self-assigned this Mar 10, 2021
SurferJeffAtGoogle added a commit to SurferJeffAtGoogle/synthtool that referenced this issue Mar 10, 2021
@SurferJeffAtGoogle
fix: tell the user autosynth may take 24 hours to regenerate
be68ca2 
fixes googleapis#978
@SurferJeffAtGoogle SurferJeffAtGoogle mentioned this issue Mar 10, 2021
Merged
SurferJeffAtGoogle added a commit that referenced this issue Mar 23, 2021
@SurferJeffAtGoogle
fix: tell the user autosynth may take 24 hours to regenerate (#981)
c84c8f1 
fixes #978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SurferJeffAtGoogle SurferJeffAtGoogle

Labels
type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: tell the user autosynth may take 24 hours to regenerate SurferJeffAtGoogle/synthtool
3 participants
@busunkim96 @SurferJeffAtGoogle @yoshi-automation