Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): remove define_artifacts from Node.js's Windows kokoro build #103

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Oct 22, 2018

We are not dumping test results to sponge.xml and it was causing issues when Kokoro tries to pull it from the VM.

@jkwlui jkwlui requested a review from theacodes October 22, 2018 23:27
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2018
@jkwlui jkwlui changed the title fix(node): remove store_artifact from Node.js's Windows kokoro build fix(node): remove define_artifacts from Node.js's Windows kokoro build Oct 22, 2018
@jkwlui jkwlui self-assigned this Oct 22, 2018
This was referenced Oct 22, 2018
This was referenced Oct 22, 2018
@JustinBeckwith JustinBeckwith merged commit ed3c514 into master Oct 22, 2018
@jkwlui jkwlui deleted the node-remove-sponge-xml-from-windows-builds branch October 22, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants