fix: release scripts from issuing overlapping phases #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mvn deploy` will run `mvn install` so specifying `mvn install deploy` is redundant at best. At worst, it will cause plugins like maven-shade-plugin to be executed twice re-shading itself
google-cla
bot
added
the
cla: yes
chingor13
approved these changes
Apr 14, 2021
chingor13
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
igorbernstein2
added a commit
to igorbernstein2/cloud-bigtable-client
that referenced
this pull request
Apr 14, 2021
gcf-merge-on-green bot
pushed a commit
to googleapis/java-bigtable-hbase
that referenced
this pull request
Apr 14, 2021
… on test artifacts (#2922) - This updates all test artifacts to disable release related plugins: deploy, nexus-staging, site, source, javadoc, gpg, & clirr. - The integration test modules were failing build because they don't have any prod classes, so maven-jar-plugin would fail because it couldnt find the primary jar. This fixes it by adding placeholder classes - Finally this pre-emptively applies changes from googleapis/synthtool#1043 fixes #2880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn deploywill runmvn installso specifyingmvn install deployis redundant at best. At worst, it will cause plugins like maven-shade-plugin to be executed twice re-shading itself