build(python): exit with success status if no samples found #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
samples
busunkim96
changed the title
busunkim96
added
the
do not merge
busunkim96
removed
the
do not merge
parthea
approved these changes
Jul 14, 2021
tseaver
reviewed
Jul 14, 2021
| @@ -21,7 +21,7 @@ set -eo pipefail | |||
| shopt -s globstar | |||
|
|
|||
| # Exit early if samples don't exist | |||
| if ! compgen -G "./samples/**/requirements.txt" > /dev/null; then | |||
| if ! find samples -name 'requirements.txt' | grep -q .; then | |||
There was a problem hiding this comment.
FWIW, find is going to emit a message on stderr for the case that the samples directory doesn't exist, e.g.:
$ find nonesuch -name foobar.txt
find: ‘nonesuch’: No such file or directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look for
requirements.txtinsamplesto check if any samples exist. The current check forsamples/doesn't always work as some repos have placeholdersamplesdirectories with READMEs.This will make it possible to add samples kokoro jobs to every repository and remove custom sync repo settings configs.
EDIT: This doesn't seem to work correctly for more deeply nested directories, I will look around to find something that works.