Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node(kokoro): Add docuploader credentials to node publish jobs #197

Merged
merged 3 commits into from
Mar 8, 2019

Conversation

busunkim96
Copy link
Contributor

No description provided.

@busunkim96 busunkim96 requested a review from jkwlui March 4, 2019 18:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 4, 2019
@busunkim96 busunkim96 changed the title Add docuploader credentials to node publish jobs node(kokoro): Add docuploader credentials to node publish jobs Mar 4, 2019
Copy link
Member

@jkwlui jkwlui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved upon resolving conflicts

@jkwlui jkwlui self-requested a review March 5, 2019 20:46
@JustinBeckwith
Copy link
Contributor

@jkwlui Please send out a hammer PR for these changes first. Those every-repo changes from synthtool are no fun :/

@busunkim96
Copy link
Contributor Author

@JustinBeckwith That was my fault, I forgot about autosynth 🤦‍♀️

@busunkim96 busunkim96 closed this Mar 8, 2019
@busunkim96 busunkim96 reopened this Mar 8, 2019
@busunkim96 busunkim96 merged commit c5abb3b into googleapis:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants